未加星标

Unlikely Memory Leak

字体大小 | |
[前端(javascript) 所属分类 前端(javascript) | 发布者 店小二04 | 时间 2017 | 作者 红领巾 ] 0人收藏点击收藏

Here’s a pretty interesting bug that a mate recently ran into that piqued my interest.

Picture this: you’re writing an MVP for an application which has some data access components - it might look like this:

class MyComponent { constructor($http) { this.$http = $http; } doSomething() { this.$http.get('http://myapi.com/some-endpoint') .then((response) => { console.log(response); this.data = response; }); } }

This probably looks familiar to a lot of you Angular developers out there.

Pretty innocuous, right?

What if I were to say that there is a reasonably annoying potential memory leak here? Most people I’ve spoken to have either scoffed or tried really hard to find something in the code that isn’t there.

Let’s take a look at what happens as this code ran over time:


Unlikely Memory Leak

Hmm… interesting. We seem to be building up a fair bit of memory usage and nothing seems to be garbage collected. Why?

It’s probably not going to be the constructor for this class, so let’s write that off. I’ll also add in the assumption that Angular’s $http service isn’t causing any leaks for us here (although it might do - but that’s a separate discussion alogether). This leaves us with the doSomething() function. We’ve all retrieved data like this in Angular applications a billion times before without any problems, right?

The solution to answering why this memory usage was accumulating had to do with how frequently doSomething() was being hit and the size of the data that was being returned in the response to the API call.

What was happening that certainly widened my eyes was that the console.log(response) was keeping a reference to response and thus not being garbage collected. I thought this was super strange because I couldn’t work out why.

By now, some people have probably worked this out. The browser developer tools uses this reference which allows us to inspect objects while we’ve logged! One of the reasons why you shouldn’t keep client-side logging in your production code.

This is how things look once the logging line is removed:


Unlikely Memory Leak

As you can see, the garbage collector is now able to kick in and remove references to our objects. I’ll also add here that this problem would arise regardless of the framework used here. It will happen even if you craft an XHR request manually and log the results.

I’m not ashamed to admit that I didn’t work this one out myself, but I certainly loved learning about it and trying to assist in diagnosing it.

Let me know what you think about this!

-Dave

本文前端(javascript)相关术语:javascript是什么意思 javascript下载 javascript权威指南 javascript基础教程 javascript 正则表达式 javascript设计模式 javascript高级程序设计 精通javascript javascript教程

分页:12
转载请注明
本文标题:Unlikely Memory Leak
本站链接:http://www.codesec.net/view/530007.html
分享请点击:


1.凡CodeSecTeam转载的文章,均出自其它媒体或其他官网介绍,目的在于传递更多的信息,并不代表本站赞同其观点和其真实性负责;
2.转载的文章仅代表原创作者观点,与本站无关。其原创性以及文中陈述文字和内容未经本站证实,本站对该文以及其中全部或者部分内容、文字的真实性、完整性、及时性,不作出任何保证或承若;
3.如本站转载稿涉及版权等问题,请作者及时联系本站,我们会及时处理。
登录后可拥有收藏文章、关注作者等权限...
技术大类 技术大类 | 前端(javascript) | 评论(0) | 阅读(40)